Robert Lipe
Robert Lipe
I like the direction here, but just a few quality issues from the peanut gallery. Even though I'm not a reviewer here, thanx for making free software better!
A lot changes in 4 years. I'd be surprised to find anything that ISN'T C++11 by now, but some systems may not provide a full implementation of modern C++ libraries....
I'd suggest backing that with strong test cases, but I agree that a fix like this is probably needed in (some subset of) the real world to support non-trivial NMEA-like...
strncpy, like strcpy, has far too many foot-guns. Most environments provide a strlcpy() that works like you intend this one to, but it also has problems. See https://lwn.net/Articles/507319/ C11 gave...
I won't put this in a PR and I won't sell you on the code, but I've had an open-source project with a many hundreds of million users (it's used...
In GPSBabel, we've concluded by observing tons of GPS dumps that if the receiver marks 'V' (not for "Valid" - quite the opposite; it's "Void") tags for the fix type...
This is the same problem fixed - in a different way - in https://github.com/jlhonora/lsusb/issues/18 also, so if you merge this one you can get a two-fer. #18 was a confirmed...
** This is a fly-by comment. I don't technically contain any relevant experience with this project, except as a user. (They work OK on the devices I've used...) I was...
It might be helpful to include a link to whatever doc told you to look for a tool of that name. However, you may find it useful to go directly...
I know nothing about this library, but since you've been waiting for months for any help, I'll share what I know about this class of lighting in general. Currently available...