Robert Lemke
Robert Lemke
The code works now and should solve the problem at hand. What's still missing are the respective test adjustments.
This is now ready for reviews.
Hmm, that's weird – all functional and unit tests succeeded in Phpstorm using PHP 7.4.
Sigh, PHP 7.3 fails. So I either need to scrub this more, so that it doesn't fail with PHP 7.3, or don't release this in Flow 7.3 but only 8.0....
This change is now targeted and rebased for master.
Thanks a lot for the accurate review! I tried to answer some questions and applied your code suggestions.
The failing tests are not related to this pull request.
@mficzel If it works for you and tests succeed, that's probably all we need right now. As for the code, just trust me – it's at least better than before...
Thanks, @kdambekalns! At this point all pending questions are answered and code suggestions were committed.
@mhsdesign very good catch! Here are my timings for comparison: | | `flow@master` | `flow@robert` | | -- | --- | --- | | neos/flow unit tests | 780ms |...