Robert Knight

> Use aria-label or aria-labelledby for form controls > Use aria-required for required fields (may be something to implement in the pattern library rather than here) This should be handled...

> Put aria-busy on the form while in loading state > Add role="img" and aria-label to the and components (again may be something we want to implement in the pattern...

I'm going to leave this PR open to track remaining work. Some notes from testing different browsers on macOS this morning: - A universal issue in all browsers is that...

> In this particular case the frame was initialised with about:blank. We have code that is supposed to handle this use case and avoid the overhead of redundantly loading the...

> Perhaps a configuration property can be introduced that determines whether the Guest gets initialised? This makes sense. Maybe something like `enableAnnotation: boolean` to control whether annotation is enabled in...

Hello, sorry for the delay in responding. > Top frame - mywebsite.com (host) > Intermediate frame - myviewer.com (injects in to child) > Child frame - myviewer.com (posts messages to...

> @robertknight no interest in this fix? Sorry, we have been preoccupied by other things. When testing these changes manually in https://github.com/hypothesis/client/pull/6902 I found it was possible to get into...

Related internal issue: https://github.com/hypothesis/support/issues/58. I'll reproduce my notes from there: >There is a CSS rule that tries to hide custom elements that are not loaded. This is unfortunately affecting our...

Hello. Thanks for the contribution. This seems like a useful feature. Since it does add significant new dependencies which may not be needed or available on some systems I would...

As a heads up, the sorting by page is being implemented in https://github.com/hypothesis/client/pull/7002. As a result you can remove that code from this PR.