Robert Hensing

Results 912 comments of Robert Hensing

Those are really good observations. "Subflake" suggests some sort of directional relationship other than just an input. We should avoid that term in the release notes, and/or explain what's not...

> At this point the `flake:root/subdir/src` and `flake:subdir/src` are locked to different revisions. I think I'm reading pseudo-syntax that's a little ambiguous, but I would think that the locking of...

> `path:..` Is your flake in a git repo? If not, that would explain the symptoms. IMO a flake should be self-contained unless a flake attribute specifies otherwise. Flakes that...

We have a few test cases [here](https://github.com/NixOS/nix/pull/10089/files#diff-48acfdb2d4eb8234e40590fa01e9af553a0a404bfe869ecbd0d4d0d4be9ce704) that suggest it should work, but maybe yours is more complicated than what we have? From what you describe I would think something...

This feature has not been implemented yet. A workaround for your use case is to perform all publish actions in a single effect, which may also be slightly more efficient,...

There's pretty much only one way to evaluate a flake, so it'd be a safe bet, but I understand that this may not be desirable. For instance, it'd be difficult...

> * `file-system.hh` functions are fine to continue to use `filesystem_error`, because they are a single implementation/interface (unlike `SourceAccessor` with multiple implementations). It is the users responsibility to make sure...

@Mic92 do you want to take another stab at this? Otherwise we could merge https://github.com/NixOS/nix/pull/11378 as an incremental fix despite the tech debt of having to fix it differently.

Note that it needs to be pure: only return the deriver field that's readily available, and don't query the store in the way `nix-store -q --deriver` does.

> PosixAccessor calls assertNoSymlinks too often? > ```python > error: path '/home/tom/.nix-defexpr/channels' is a symlink" thrown in the test body. > ``` This is probably the right behavior for a...