Robert Hensing

Results 909 comments of Robert Hensing

This choice was made because git supports this: > Patterns which a user wants Git to ignore in all situations (e.g., backup or temporary files generated by the user’s editor...

You could make it conditional here https://github.com/hercules-ci/gitignore.nix/blob/211907489e9f198594c0eb0ca9256a1949c9d412/find-files.nix#L109 and add parameters all the way up. I'd like the 'public' interface `gitignoreSource` and `gitignoreFilter` to be backcompatible. You could introduce `*With` functions;...

I've updated [the comparison](https://github.com/hercules-ci/gitignore.nix#comparison). I'm becoming increasingly convinced that gitignores are a fight that can't be won. If you really care, you'll want to use explicit inclusion rules, rather than...

That's something that should be solved in Nixpkgs Haskell. Coupling with arbitrary users of the gitignore functions invites a lot of churn and temptation to create all sorts of backwards...

Hey Domen, that doesn't look like fun. Could you check that `postgres-data` is actually gitignored? I've looked at the source location in the trace, but it's an odd coordinate. Are...

It looks like either hydra is putting sources in the store before evaluating, or you're invoking gitignore on a source that's already in the store. Could you enable --show-trace and/or...

You can achieve this by using [gitignoreFilter](https://github.com/hercules-ci/gitignore.nix/blob/master/docs/gitignoreFilter.md) directly. Since you're using hpack, you might be interested in [pre-commit-hooks.nix](https://github.com/cachix/pre-commit-hooks.nix), which had hpack support [merged](https://github.com/cachix/pre-commit-hooks.nix/pull/41) recently.

You can modify the filter expression at the nix level with [gitignoreFilter](https://github.com/hercules-ci/gitignore.nix/blob/master/docs/gitignoreFilter.md), but currently there's no interface for inserting extra rules, or for working off manually provided rules only. These...

Your goal can already be achieved through `cleanSourceWith { filter = filterThisThat; src = gitignoreSource ./source; }`. Reasons you may still need a feature like this: - for adding negative...

> you are saying that this project doesnt support negative rules `gitignoreSource` does already support negative rules, but `cleanSourceWith` can not merge in any negative rules that weren't in the...