ansible-role-logrotate icon indicating copy to clipboard operation
ansible-role-logrotate copied to clipboard

feat: add ability for multiple entry paths and postrotate commands

Open tazend opened this issue 1 year ago • 2 comments

Hi,

this branch is based on #8 which fixes the unnecessary blank lines the current template produces.

Describe the change This branch also adds the ability to specify a list for the path and postrotate variable, as having multiple paths and postrotate-commands is perfectly fine in logrotate. It is however still possible to simply specify a single string as before (just to not break existing setups) - necessary checks where added in assert.yml (Fixes #15)

Testing I checked the result produced by the template and it looked fine, both for multiple and single paths/postrotate commands.

tazend avatar Jun 27 '23 07:06 tazend

@tazend it has been a while since you authored this PR. Are you still hoping to have it merged, or have you moved onto a different solution? I'm asking because I've just discovered @robertdebock's role, and I have the same requirement that you did when you raised this change - to be able to specify entry path as a list in addition to being able to specify a single item.

If you're not wishing to pursue this any further, I will add the functionality myself in a separate PR, in the hope that it will get merged. Thanks!

danrough avatar May 23 '24 21:05 danrough

@danrough I still hope to have it merged at some point. At the moment I just use the branch of my fork where its implemented. I'll try to fix the merge conflicts in this PR though.

tazend avatar May 24 '24 15:05 tazend