Robert Bastian

Results 55 issues of Robert Bastian

The following snippet panics because `HelloWorldProvider` doesn't have fallback data ```rust DatagenDriver::new() .with_keys([icu_provider::hello_world::HelloWorldV1Marker::KEY]) .with_locales_no_fallback([langid!("de")], Default::default()) .export( &icu_provider::hello_world::HelloWorldProvider, icu_datagen::blob_exporter::BlobExporter::new_with_sink(Box::new(std::io::sink())), ) .unwrap(); ```

question

In preparation for #3632 There are two cases: * `DataLocales` that are passed into ICU4X constructors: * These are constructed with `locale!("foo").into()`, or `"foo".parse()` * When changing a constructor to...

This started out as docs improvements, but I've also touched non-docs code now. ```rust let collator: Collator = Collator::try_new(...); ``` becomes ```rust let collator = Collator::try_new(...); ``` ====== ```rust let...

PRs I'd like inluded: * https://github.com/unicode-org/icu4x/pull/4904 * https://github.com/unicode-org/icu4x/pull/4903 ## Pre-release checklist This is a checklist of things that should be done in the weeks leading to the release. * [x]...

discuss-priority

It's usually better if the callers calls `x.into()` or `&x`