Robert Bastian
Robert Bastian
What about datagen? Which crate(s) should it use to name data structs?
*databake, not datagen. What prefix should we use in the generated files? Clients will have to import different crates depending on that.
Yes we need an option for both, but I believe `icu::` should be the default
I'm somewhat disillusioned about this. Ignoring all traits other than `Writeable`, our API surface is still more than 1000 elements (and this already excludes functions like `From::from` and `ToString::to_string` which...
Yeah but * This doesn't list all functions we do want FFI for (because bug) * This lists lots of functions that we do not want FFI for so this...
What exclusions do you have in mind?
I don't think direct conversions add any value over just going through `.iter().collect()`. I don't think there are any optimisation possibilities, because `LiteMap` stores the tuples together, and `ZeroMap` breaks...
Oh sorry I don't seem to have invoked `rustfmt` correctly. `rustfmt +nightly --config format_code_in_doc_comments=true,doc_comment_code_block_width=80 provider/adapters/src/fallback/mod.rs` doesn't work with the file at https://github.com/unicode-org/icu4x/blob/583de584f0ba1cfe3402915989f57aa586c0ca06/provider/adapters/src/fallback/mod.rs. The inner doc comment has a line that's...