Robert Basic comments

Results 61 comments of


                                            Robert Basic

Creating an alias or overload of an interface containing __construct fails

@chappy84 ah, you're right. I'll investigate some more.

Creating an alias or overload of an interface containing __construct fails

@chappy84 what is your use case for this? The `alias:` and `overload:` "operators" are in Mockery to provide aliasing/overriding already existing classes, so to me adding additional interfaces to those...

Creating an alias or overload of an interface containing __construct fails

@chappy84 you are right, again, about that part. But I still don't understand you're use case.

Proposal: Verify that quick definitions for default expectations are called at least once

I'm sorry, this totally went past me. First, adding atLeast->once to the test doubles will turn them from stubs to mocks, as you now have expectations on them. Having the...

Proposal: Verify that quick definitions for default expectations are called at least once

@danydev I've left feedback on the PR

Proposal: Verify that quick definitions for default expectations are called at least once

@danydev I'm sorry, I'm swamped with work and personal stuff, I don't have much time to dedicate to oss

Drop hhvm support

Sure, I'm OK with that.

ExpectationInterface is missing methods that the Expectation class has.

@slepic thanks for your detailed issue and PR, but I think this needs a deeper looking at. This does feel like it should belong into a 2.0.0 release, but that...

Non exact count matching broken when using expects()

Yes, that is the expected behaviour of `expects()` http://docs.mockery.io/en/latest/reference/alternative_should_receive_syntax.html#expects as we are expecting an exact number of calls to that method. On the other hand, `allows()` allows a varying number...

Non exact count matching broken when using expects()

We thought that the distinction is clear enough from the actual method names: `expects` vs `allows`. The things is that `atLeast` and `between` allow a method to be called from...