Robert Kruszewski

Results 111 comments of Robert Kruszewski

Here's the logic to infer the constraints https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala#L113

While they do support them internally they never push them down through optimizer so we have to wait for more datafusion features to land before we do anything here. Let's...

I have forgotten that we filter expression, it's there

The general difficulty we have as a framework that wants to do its own filtering we have our own expression representation and as such we can't just take a datafusion...

I am confused by this change - isn't @cimport going to go away and translate_c is going to be the only way forward? I would prefer to figure out a...

I see, had to read the upstream zig issue. We can merge this and go back to translatec with zig 0.16

I think if we have #526 we do not need this?

The logic is duplicated right now because our untrusted logic is buggy, in practice it will leak memory in case of a panic from the `Iterator::next` call. If we fix...

It's not a leak you're right, I misread the comments in the stadard library. The reason why I don't think we should remove it is that standard library doesn't remove...

I’m just reading source code for Vec which this logic is based on