programming-feedback-for-advanced-beginners icon indicating copy to clipboard operation
programming-feedback-for-advanced-beginners copied to clipboard

Diff view between "original" and "updated"

Open baogianghoangvu opened this issue 5 years ago • 5 comments

Hi. Thank you so much for starting this series.

I wonder if it's possible (and not too much of a hassle) to make use of git's diffing to highlight the differences between 2 files.

I think one option is to first commit "updated" as an exact copy of "original", then commit your recommendations on top of "updated", so git history has the diffs between the original state and the final state. Then it's also possible to highlight the recommendations part-by-part by breaking them down into multiple commits.

Thank you again!

baogianghoangvu avatar Nov 13 '19 13:11 baogianghoangvu

Hi! Thanks for the suggestion - I think it's a great idea. I will definitely look into this and update the existing edition when I can. If you fancy having a go and showing me what you would find most useful then I'd gratefully receive a PR :)

robert avatar Nov 17 '19 13:11 robert

Robert, first let me thank you for taking such an ambitious project! I enjoy your blog and look forward to reading all of it! I think baogianghoangvu is on to a very important and larger point. Revision control is an critical part of effective software development. There are many ways to integrate it into your lessons and I would like to see that. Again thanks for your efforts!

mcastrigno avatar Jan 08 '20 19:01 mcastrigno

Thanks for the comment @mcastrigno - this definitely makes sense. I'll see what I can do in future editions.

robert avatar Jan 13 '20 19:01 robert

Hi! Sorry for the late reply & PR. I've made an attempt at PR #2. Please have a look. Hope this helps!

baogianghoangvu avatar Jan 14 '20 09:01 baogianghoangvu

@robert Also, if you have a look and think the approach & format in PR #2 is ok, I'd be happy to do the same for the other PFAB blogposts.

baogianghoangvu avatar Jan 14 '20 09:01 baogianghoangvu