Rob Heaton comments

Results 18 comments of


                                            Rob Heaton

Show the actual value of the flags registers if there is a mismatch in the lower nybble

Ahh do you mean show the full 2-digit hex, rather than just the 4 flags? In case there's a mismatch in the bits in the F register outside those used...

Show the actual value of the flags registers if there is a mismatch in the lower nybble

👍 makes sense, I'll do that at some point!

Show the actual value of the flags registers if there is a mismatch in the lower nybble

Thanks for the vote, I'll keep this in mind. If you're interested in submitting a patch then that would be awesome, although the code is a little gnarly so might...

Show the actual value of the flags registers if there is a mismatch in the lower nybble

Heh you're probably right. Do you think we should change anything about gameboy doctor or is this just interesting trivia?

Suggestion: add the first four bytes from the stack top to the trace

Sounds reasonable, want to try a PR? Maybe with a `--with_stack` argument so people can choose not to use this.

Unexpected mismatch

Thanks for your messages both. @cluoma to make sure I understand - you think that the example logs are correct, but users have to make sure to insert their logging...

Unexpected mismatch

@Ptival thanks for tracking that down - would you be up for making a PR with a README.md update that would have made this clearer for you?

Suggestion: Include last address and value written to by the CPU

That does sound useful! It sounds a bit harder to instrument to me, and the example logs would have to be regenerated. I think we'd want a flag or some...