Cluffer icon indicating copy to clipboard operation
Cluffer copied to clipboard

switch line content from make-string to make-array

Open mgi opened this issue 8 years ago • 4 comments

without this the climatis-gui of second-climacs fail to render text.

mgi avatar Mar 02 '16 14:03 mgi

Cluffer is meant to be able to handle buffer contents other than characters. One possible way out is to check whether the line contents consists only of character, and in that case create a string, and otherwise create a simple vector.

But that would require modifying the tests as well, so that a simple vector from the simple line implementation can be compared to a string coming from the standard line implementation.

If you want to work on that, that would be great, but don't feel you have to.

robert-strandh avatar Mar 03 '16 07:03 robert-strandh

Robert Strandh [email protected] writes:

Cluffer is meant to be able to handle buffer contents other than characters.

Yes, I thought that was that. In fact, I did this modification while giving a try to Second-Climacs/CLIMatis GUI because this vector ends up in a clim3-ext:paint-text call that needs a string. Maybe I could coerce at the last time but thought it was ugly.

One possible way out is to check whether the line contents consists only of character, and in that case create a string, and otherwise create a simple vector.

But that would require modifying the tests as well, so that a simple vector from the simple line implementation can be compared to a string coming from the standard line implementation.

If you want to work on that, that would be great, but don't feel you have to.

In fact, I'd like to know what do you think requires the most

attention/work in CLIMatis for instance.

Manuel Giraud

mgi avatar Mar 03 '16 08:03 mgi

Hello,

The easiest fix right now is to adapt the code of Second Climacs so that it can handle objects other than characters, perhaps by ignoring them or replacing them with some neutral character.

The most urgent aspect of CLIMatis is unfortunately a design decision, namely to figure out how to implement presentation types. It would be possible to just import everything from McCLIM, but I think it should be simplified.

A simpler aspect that also needs to be taken care of is to define a set of lowest-level drawing primitives in a way similar to CLIM II, and then to define the drawing in various zones in terms of those drawing primitives.

Take care,

On Thu, Mar 3, 2016 at 9:51 AM, Manuel Giraud [email protected] wrote:

Robert Strandh [email protected] writes:

Cluffer is meant to be able to handle buffer contents other than characters.

Yes, I thought that was that. In fact, I did this modification while giving a try to Second-Climacs/CLIMatis GUI because this vector ends up in a clim3-ext:paint-text call that needs a string. Maybe I could coerce at the last time but thought it was ugly.

One possible way out is to check whether the line contents consists only of character, and in that case create a string, and otherwise create a simple vector.

But that would require modifying the tests as well, so that a simple vector from the simple line implementation can be compared to a string coming from the standard line implementation.

If you want to work on that, that would be great, but don't feel you have to.

In fact, I'd like to know what do you think requires the most

attention/work in CLIMatis for instance.

Manuel Giraud

— Reply to this email directly or view it on GitHub https://github.com/robert-strandh/Cluffer/pull/1#issuecomment-191658455.

Robert Strandh

robert-strandh avatar Mar 09 '16 07:03 robert-strandh

Robert Strandh [email protected] writes:

The most urgent aspect of CLIMatis is unfortunately a design decision, namely to figure out how to implement presentation types. It would be possible to just import everything from McCLIM, but I think it should be simplified.

Hello,

Ok this part seems like something hard and for someone already understanding CLIM II inside out.

A simpler aspect that also needs to be taken care of is to define a set of lowest-level drawing primitives in a way similar to CLIM II, and then to define the drawing in various zones in terms of those drawing primitives.

Maybe, I could give that part a try. I think clim-ext:paint-paths can already handle some cases here.

Thanks,

Manuel Giraud

mgi avatar Mar 09 '16 08:03 mgi