pydstool icon indicating copy to clipboard operation
pydstool copied to clipboard

C code for Dopri/Radau interface to Python is awful

Open z2v opened this issue 10 years ago • 3 comments

Needs refactoring and whitespace clean up.

z2v avatar Nov 21 '14 07:11 z2v

Agreed. The ctypes rewrite that I sent you should help to show how this can be done more simply.

robclewley avatar Nov 21 '14 15:11 robclewley

@robclewley, for now I am not ready to rewrite interface. I'm just going to remove some duplication and to fix formatting. In preparation for memory problems fixing.

Current code is tested and works somehow :). And, as it seems to me, after migration from numarray to numpy there are no strong points for immediate rewriting. Though, in general, it makes sense. What do you think?

z2v avatar Nov 25 '14 10:11 z2v

@z2v, that's fine, you've done a lot already! The ctypes prototype interface is much simpler and most likely a few percent faster but we'll get to that when someone has more time. I posted one more irritating issue about pickle that it would be nice to have fixed for this release. I don't think I'll have time to do it before the conference that I'm preparing for, but it's not a big deal either way. Thanks.

robclewley avatar Nov 25 '14 15:11 robclewley