pysystemtrade icon indicating copy to clipboard operation
pysystemtrade copied to clipboard

Published 20 hours ago • verified publisher icon robcarver17

Fixed code errors

Open Eeonum opened this issue 10 months ago • 2 comments

diagPrices changed to diag_prices in rollcalendars_from_arcticprices_to_csv.py and multiple_and_adjusted_from_csv_to_arctic.py

Eeonum avatar Apr 09 '24 06:04 Eeonum

This pull request includes several other changes from your fork that you probably didn't intend to include. You'll need remove them before this can be merged.

Also, are you sure this should be merged into master rather than develop? The general idea is that most changes will be done in develop first, and develop will eventually be merged into master when it is considered to be reasonably stable.

tgibson11 avatar Apr 09 '24 14:04 tgibson11

It should be part of the master's as this is final. I tried to fix the redundancies, but can you remove adding the CSV files on your end if it didn't work? The rest should be added to the master.

Eeonum avatar Apr 09 '24 14:04 Eeonum