robbietuk

Results 41 comments of robbietuk

In light of #901, I am more so inclinded to add an intermediate class, i.e. `Gibbs prior`, that the Quadratic, Relative Difference Prior, Parallel Level Sets, LogCosh, and (Huber +...

Can also embed status images in the main README. Maybe a useful [link](https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge)?

Some comments: - ML norm code currently uses `num_crystals_per_block`, it should use `num_crystals_per_bucket` instead - The handling of virtual crystals in a block/bucket configuration might take some thinking about. -...

I have given this a shot and while I thought it would be nice and easy, there are ~180 uses of `foobar_per_block` mentions that simply need to be replaced with...

This may not still be an issue since #181 was merged. Would need testing

I have been looking at `GeometryBlocksOnCylindrical::build_crystal_maps` and I am wondering if there is something wrong with the loop ranges. https://github.com/UCL/STIR/blob/ee307c721cae562ab163aee06dbab8407d861414/src/buildblock/GeometryBlocksOnCylindrical.cxx#L102-L104 Should the second loop terminate at `num_axial_blocks_per_bucket = 2`, not...

> I wonder why I never ran into any issues with this I believe that most of the tests use a single axial bucket and that doesn't encounter any issue.

I will create a PR with the aforementioned test and an attempted fix today.