chrome-aria2-integration icon indicating copy to clipboard operation
chrome-aria2-integration copied to clipboard
verified publisher icon robbielj

With Cookie

Open Immortalin opened this issue 10 years ago • 2 comments

Can you add an option to include the cookies of the current page?

Immortalin avatar Dec 20 '15 09:12 Immortalin

Actually the code looks like this already used to work in the past. I think I found a fix to make it work again, please see my pull request.

roooneey avatar Jan 24 '16 23:01 roooneey

Uhm, that's probably the reason why cookes didn't seem to work for me when using this extension. If the domain at which link is posted is NOT the same as the domain of the link, wrong cookies are being used.

Steps to reproduce:

  1. Create proper (plain text) cookies file in aria2 config for "files.com"
  2. Manually add aria2 download from CLI specifying load-cookies and make sure it works
  3. In Chrome go to "list.com" which has links to downloads at "files.com"
  4. Right-click on any download link and select "Download with Aria2".

Result: wrong cookies are being used, if "files.com" relies on cookies to ID users it results in failed download.

If I may make a suggestion, either of the steps below should work:

  1. Compare the download URL against the current page URL and if the domains are different do not send any cookie information to aria daemon
  2. Send the cookie of the download URL domain rather the current page domain to aria daemon

Unfortunately I'm not skilled enough to patch code, could anyone fix it please?

stangri avatar Apr 16 '16 11:04 stangri