KissXML
KissXML copied to clipboard
Fix Xcode compiler warning: Implicit conversion loses integer precision:...
... 'NSUInteger' (aka 'unsigned long') to 'int'
:+1:
+1
+1, but this is also covered by PR #39.
Simply silencing this one with a cast may not be the right call. - [NSData length]
returns an NSUInteger
, which is either an unsigned int
(on 32 bit systems) or an unsigned long
(on 64 bit systems). This value is being passed to a libxml function that is expecting an int
, which I believe is always a 32 bit number.
So if it's a possibility that the length of the data exceeds 2^32-1, then there should be some code that checks that case. Is that a possibility? Seems like it'd be a pretty crazy edge case if it is...
After understanding that concern, I say we just cast it and get rid of this annoying warning :)
+1