robbert-vdh
Fix reference cycles in VST3/CLAP wrappers
This PR resolves #222, which was caused by the execute_background and execute_gui callbacks both receiving a strong clone of their parent wrappers' Arcs, leading to a reference cycle.
I've gone for the most obvious fix in this situation - just downgrade the Arcs before moving them into their respective callbacks, and ignore any tasks posted after the wrappers have been dropped. I've confirmed that this resolves the memory leak (and the subsequent VST3 crash in FL Studio), and I haven't noticed any issues caused by dropping the tasks -- though please correct me if I'm wrong on that.
How are you building the plugins? I tried building spectral_compressor with cargo xtask bundle spectral_compressor --release --target=x86_64-pc-windows-gnu (cross compiling to windows from linux) and the FL Studio freeze still happens in my Windows 11 VM
(edit) Nevermind, I ended up compiling it from within the VM (tried x86_64-pc-windows-gnu and x86_64-pc-windows-msvc) and it's the same thing 😭, it doesn't seem to fix the issue for me
(edit 2) I just realized there's a possibility that I may be compiling it wrong still
