Cartography icon indicating copy to clipboard operation
Cartography copied to clipboard

Published 20 hours ago • verified publisher icon robb

Xcode11 build issue fix

Open luko-g opened this issue 4 years ago • 7 comments

Because constrain function is defined in CommonUISDK looks like XCode11 cannot compile Cartography pod anymore. Renaming constrain functions to cg_constrain seems to fix the problem

closes: https://github.com/robb/Cartography/issues/313

luko-g avatar Oct 08 '19 18:10 luko-g

This is a pretty drastic API change - are there any other ideas to make this work?

orta avatar Oct 08 '19 22:10 orta

@orta I guess you can leave it as is and just expect everyone to use namespaces. Cartography.constrain

luko-g avatar Oct 09 '19 18:10 luko-g

I think this is probably better, yeah 👍

Any chance you can update docs and then this is good to go?

orta avatar Oct 10 '19 19:10 orta

Any update on this? Can we push this up if everything looks fine?

SudeepKS88 avatar Oct 22 '19 19:10 SudeepKS88

This changes the API in a way that makes all the README's examples not work - happy to have you fix that in a PR with these changes also?

orta avatar Oct 22 '19 22:10 orta

Happy to have someone re-implement the PR with the feedback rather than wait

orta avatar Oct 27 '21 08:10 orta