Robert O Butts comments

Results 29 comments of


                                            Robert O Butts

grpclog: change logger to avoid Printf when the logger is io.Discard

> I'm sorry, but I merged a change recently that refactored the logging implementations. So, this PR might have significant merge conflicts now. I fixed the conflicts.

grpclog: change logger to avoid Printf when the logger is io.Discard

Ok, I think I addressed all the comments again. Let me know if I missed anything. Also, the PR started failing a new Github check for `RELEASE NOTES` in the...

grpclog: change logger to avoid Printf when the logger is io.Discard

Is there anything else I need to do for this to be merged?

grpclog: change logger to avoid Printf when the logger is io.Discard

> This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7...

grpclog: change logger to avoid Printf when the logger is io.Discard

N.B. I made a few changes since the last review, adding ```go var sprintf = fmt.Sprintf var exit = os.Exit ``` in loggerv2.go, to make it possible to test that...

Cache needs invalidated for PATCH and unknown methods

This is trivial to fix, but I'm only like 95% sure the above is all true and correct. Someone else confirming would be good.

Cache needs invalidated for PATCH and unknown methods

See also https://github.com/apache/trafficserver/pull/7999

Add Generic Traffic Ops Config Endpoint

I'll also note, this is less of an issue than it used to be. Especially with the transition from DeliveryService-Servers to Topologies. When I made this Issue, I don't think...

Add t3c flag to avoid systemd

I feel like it'd be valuable anyway, not just for the CiaB, to have a flag that says "never do system stuff," so someone could allow it to work in...