rob-scheepens

@Gt3pccb : correct, see https://github.com/prometheus-community/windows_exporter/issues/799#issuecomment-886566205, where it is mentioned that using Get-Counter is undesirable. See https://github.com/prometheus-community/windows_exporter/issues/799#issuecomment-858376472 and following few comments on using Get-CimInstance. I'm not a developer, but perhaps using...

@Gt3pccb : while you can use PDH from PowerShell, it is meant to be consumed from app code. Example of importing pdh.dll in PowerShell: https://powershellmagazine.com/2013/07/19/querying-performance-counters-from-powershell/ On the latencies: this is...

@breed808 @CatMerc : I imported win_perf_counters in https://github.com/rob-scheepens/windows_exporter/blob/rob-physical_disk-collector/collector/physical_disk.go#L13. What would be the next step to invoke PDH functionality from physical_disk.go? cc: @carlpett

Updating to later QEMU ensured that xtopology cpuid feature was also exposed, now PCM is working.

> @rob-scheepens I don't think Calle's available at the moment. I could step in and review based on the existing comments. > > Could you rebase the feature branch on...

Closing this since we now have a working version of physical_disk collector using PDH instead of Perflib, as mentioned in https://github.com/prometheus-community/windows_exporter/issues/799#issuecomment-1406568524. A PR for that will follow shortly.

Eventually I could reopen this PR, due to GitHub issues. I closed the duplicate I created of this, PR 1211.

@breed808 @carlpett : could you please (re)review this?

@breed808 thanks for checking, and yes, we're happy with the disk number.

Still happening on Monterey. Previously I fixed it using https://gist.github.com/davesilva/da709c6f6862d5e43ae9a86278f79188, but now that does not work, and I am at a loss to figure out what the difference is.