FreeTensor icon indicating copy to clipboard operation
FreeTensor copied to clipboard

Remote task scheduler test

Open atlas5301 opened this issue 2 years ago • 15 comments

bug fixed(but still with some methods left blank)

atlas5301 avatar Aug 03 '22 15:08 atlas5301

Please document the whole procedure and/or what each functions do in corresponding docstrings. I can't really follow your code.

roastduck avatar Aug 04 '22 02:08 roastduck

This pull request introduces 1 alert when merging 00754e997485940bb845175c9fcab5c1c3fac189 into 2b605035cee4180e99661165061357ca038ac4a3 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

lgtm-com[bot] avatar Aug 04 '22 09:08 lgtm-com[bot]

AFAIK Python has GIL such that no Python code can be interpreted simultaneously in different threads. Are you sure the code is actually running in multi-thread? Is it possible to really eat up a multi-core CPU?

Blealtan avatar Aug 04 '22 11:08 Blealtan

This is certainly an unfinished version, but a full_test code is added. The test submits a remote measure task and also shows how the measure task is splitted and merged. The whole procedure can be done smoothly. Most bugs are fixed (as the test can be operated)

atlas5301 avatar Aug 04 '22 15:08 atlas5301

Further updates included: better coding style, better error correction, potential bug fixes ,better log method and a bunch of test-cases(pytest)

atlas5301 avatar Aug 04 '22 15:08 atlas5301

This pull request introduces 5 alerts when merging 629461ecc3fe19a16db5eaf766a92dc327d04486 into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 3 for Unnecessary pass
  • 2 for Unreachable code

lgtm-com[bot] avatar Aug 04 '22 15:08 lgtm-com[bot]

This pull request introduces 5 alerts when merging 6959ee1f42d2485da30eae9471c1fe7bb2c7246e into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 3 for Unnecessary pass
  • 2 for Unreachable code

lgtm-com[bot] avatar Aug 04 '22 17:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging e302f41d742962be4391f7beaf06fbec91a45ce0 into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 2 for Unnecessary pass
  • 1 for Unreachable code
  • 1 for Suspicious unused loop iteration variable

lgtm-com[bot] avatar Aug 05 '22 09:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging b9cf22225680a6cc0451d4757015e17fadc6e5bd into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 2 for Unnecessary pass
  • 1 for Unreachable code
  • 1 for Suspicious unused loop iteration variable

lgtm-com[bot] avatar Aug 05 '22 10:08 lgtm-com[bot]

This pull request introduces 2 alerts when merging 2c14803573819caf87a08e18800d0fb10636b893 into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace
  • 1 for Suspicious unused loop iteration variable

lgtm-com[bot] avatar Aug 05 '22 11:08 lgtm-com[bot]

This pull request introduces 2 alerts when merging b1db797d59c75a3c1974189ae6d683fc923dee43 into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace
  • 1 for Suspicious unused loop iteration variable

lgtm-com[bot] avatar Aug 05 '22 11:08 lgtm-com[bot]

This pull request introduces 2 alerts when merging 4ee3a4b2bf4280c3dfa3a229cd44680784a90a78 into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

lgtm-com[bot] avatar Aug 05 '22 12:08 lgtm-com[bot]

This pull request introduces 3 alerts when merging 24fa411d5f0e1c56a2fbfbd1262d584df110c5fe into 4ff782e1651eb37fa4590aa09793ee740b68eaa4 - view on LGTM.com

new alerts:

  • 1 for Unnecessary pass
  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

lgtm-com[bot] avatar Aug 05 '22 18:08 lgtm-com[bot]

This pull request introduces 1 alert when merging 3b15092fd0df7d2022e56ac922ccb6fde1a1d9f3 into f76e7dfe4e57a222e6a38689d5e83a179043e023 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

lgtm-com[bot] avatar Aug 05 '22 21:08 lgtm-com[bot]

This pull request introduces 1 alert when merging d0ce987978c6c326e21808c57cd65833ca50971c into c7a0090eb84aa36146d2b64cc33ad39bf1fbb7aa - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

lgtm-com[bot] avatar Aug 06 '22 08:08 lgtm-com[bot]