roam-toolkit icon indicating copy to clipboard operation
roam-toolkit copied to clipboard

Shortcuts for navigating between sidebar panels in Vim Mode

Open tntmarket opened this issue 5 years ago • 7 comments

This makes the panel navigation shortcuts more compatible for both the default Roam experience and horizontal themes (https://github.com/tntmarket/roam-toolkit/pull/5):

Demo with vanilla theme: https://www.youtube.com/watch?v=jsGXeVCcAvc Demo with horizontal theme: https://www.youtube.com/watch?v=tPkDJKHU4SY

This is not exactly "backwards compatible", because you can no longer navigate between sidebar pages with straight up j/k etc.

I feel like it matches the behavior of "vim windows" more closely though, and it makes it so gg and G go to the beginning/end of the sidebar page, rather than the whole sidebar.

tntmarket avatar Aug 30 '20 00:08 tntmarket

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 30 '20 00:08 sonarqubecloud[bot]

Hey @lkhphuc and @TDHTTTT, here's a demo of shortcuts that should work better with horizontal themes, what do you think? https://www.youtube.com/watch?v=tPkDJKHU4SY

tntmarket avatar Aug 30 '20 00:08 tntmarket

Hey that look nice. Thank @tntmarket . Looking forward to this.

lkhphuc avatar Aug 31 '20 11:08 lkhphuc

I use the non-horizontal theme and I heavily use the navigation between panels, so I would not want to loose that =\

Stvad avatar Sep 13 '20 23:09 Stvad

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 11 '20 19:10 sonarqubecloud[bot]

I use the non-horizontal theme and I heavily use the navigation between panels, so I would not want to loose that =\

Maybe we can have sidebar pages be separate panels, but make it so navigating past the current panel takes you to the next panel?

tntmarket avatar Oct 11 '20 19:10 tntmarket

That should work, I think :)

Stvad avatar Oct 11 '20 22:10 Stvad