roam-toolkit icon indicating copy to clipboard operation
roam-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon roam-unofficial

Present SRS metadata with a colored pill, instead of raw text attributes

Open tntmarket opened this issue 5 years ago • 10 comments

This reverts to the [[]] style of block properties, in order to be able to fully hide the metadata with css. The metadata is still readable if you edit the block.

It displays the review interval, and colors the pill according to the ease factor.

I'm not sure if I should include the css in roam-toolkit itself. Maybe better to link to some example css in the documentation, in case it looks ugly with certain css themes, or if people want to tune the presentation based on values.

Screen Shot 2020-07-12 at 3 20 19 AM

Here is the full css being generated: https://gist.github.com/tntmarket/9dc7179e9c8c0357b87fbbeed3eedfc9

tntmarket avatar Jul 12 '20 10:07 tntmarket

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 12 '20 10:07 sonarqubecloud[bot]

I like it but am a bit conflicted :)
The reason for moving away from the old format was to get rid of thousands of additional pages generated by liberal use of SRS (each unique interval and each unique factor gets a page)

Regarding injecting CSS - I think it's ok to do so, as long as people can override styles (so we should have doc on those)

Also a majority of my prompts would be in 1+ month :) I'd like more granularity then that (probably up to a few years)

Stvad avatar Jul 12 '20 19:07 Stvad

As a curiousity/fyi - another way to make the thing render in "special way" is to surround it with double {} like {{[[interval]]:5}}. That's gonna render as a button, won't create an additional page, but the button won't have the special css classes either though =\

Stvad avatar Jul 12 '20 22:07 Stvad

the days should be shifted in +1 direction for this as the fractions are rounded up for the purposes of scheduling. so interval 4.2 would result in scheduling in 5 days.

Stvad avatar Aug 16 '20 19:08 Stvad

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 23 '20 04:08 sonarqubecloud[bot]

Is it possible to add css buttons that can do the function of ctrl-shift-x ? for how well recall is?

Jaydon-chai avatar Aug 25 '20 07:08 Jaydon-chai

It's possible, but it'd involve more then just CSS, it'd require custom rendering of blocks. Which is not trivial (not that complicated either, but requires some work)

Stvad avatar Aug 25 '20 16:08 Stvad

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 11 '20 19:10 sonarqubecloud[bot]

@tntmarket are you just updating the current version with latest changes from master, or did you find a way to make it work better?

Stvad avatar Oct 11 '20 22:10 Stvad

@tntmarket are you just updating the current version with latest changes from master, or did you find a way to make it work better?

Oh sorry, I've just been pushing my personal customizations to this branch, I'll start using another branch

tntmarket avatar Oct 11 '20 23:10 tntmarket