roadrunner
roadrunner copied to clipboard
Fix JSON errors in JSON schema
Reason for This PR
The patternProperties logic was defined at the wrong location, causing the entire JSON schema validation logic to not work for keys under jobs.pipelines.pipeline_name.
I also cleaned up a bunch of typos and various inconsistencies and errors I found on the way.
The update to the SQS section assumes that https://github.com/roadrunner-server/sqs/pull/570 will be merged, as these changes are in line with the documentation changes from https://github.com/roadrunner-server/docs/pull/27.
I moved reused properties from queues (priority, prefetch, consume_all and queue) to the definitions section for reuse.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
- [x] All commits in this PR are signed (
git commit -s). - [ ] The reason for this PR is clearly provided (issue no. or explanation).
- [ ] The description of changes is clear and encompassing.
- [ ] Any required documentation changes (code and docs) are included in this PR.
- [ ] Any user-facing changes are mentioned in
CHANGELOG.md. - [ ] All added/changed functionality is tested.
Summary by CodeRabbit
-
New Features
- Introduced
PipelinePropertiesfor streamlined configuration of queues. - Added new services (
some_service_1andsome_service_2) to the configuration file. - Introduced health check endpoint for improved application monitoring.
- Added new metrics configuration for application-specific metrics.
- Added new configurations for NATS, AMQP, Beanstalk, and SQS jobs drivers.
- Introduced
-
Enhancements
- Updated descriptions and examples for
sqsproperties, improving clarity on usage. - Refined descriptions for
jobsproperties to better explain functionality. - Changed default permission for
BoltDBfrom a string to an integer for consistency. - Expanded logging settings for more granular control over log levels.
- Enhanced Redis configuration to specify connection details.
- Updated Kafka driver configuration to clarify the transaction timeout.
- Modified HTTP plugin settings to change the internal error code.
- Updated descriptions and examples for
-
Documentation
- Enhanced clarity and organization of the JSON schema for easier user implementation.