roadrunner icon indicating copy to clipboard operation
roadrunner copied to clipboard

[💡 FEATURE REQUEST]: Replace `zap` logger with the official Go `log/slog` logger

Open rustatian opened this issue 1 year ago • 5 comments

Plugin

Logger

I have an idea!

The Golang official log/slog package is out from the experimental packages. It is time to update our zap logger from Uber with the official one.

rustatian avatar Oct 13 '23 14:10 rustatian

Can i help you with this epic? Looks like there many simple work for PHP dev @rustatian

Kaspiman avatar Apr 03 '24 06:04 Kaspiman

I'm still not sure about this ticket. According to the benchmarks, slog is much much slower than zap: link.

rustatian avatar Apr 03 '24 16:04 rustatian

@Kaspiman btw, if you want to contribute, I can suggest you this ticket: https://github.com/roadrunner-server/roadrunner/issues/1742. Here, you may use json-rpc like payloads with method mapping to the RR RPC methods.

rustatian avatar Apr 03 '24 17:04 rustatian

@rustatian I'm interested in implementing this feature, because of https://github.com/roadrunner-server/roadrunner/issues/1708#issuecomment-1761611248

Kaspiman avatar Apr 03 '24 18:04 Kaspiman

To move to the official packages, it has to be at least not so behind the zap in terms of performance. I don't think, that the slog update happened this year.

rustatian avatar Apr 03 '24 19:04 rustatian