laravel-bridge icon indicating copy to clipboard operation
laravel-bridge copied to clipboard

Add gRPC client support

Open hungthai1401 opened this issue 6 months ago • 2 comments

Description

  • gRPC client support

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I wrote unit tests for my code (if tests is required for my changes)
  • [x] I have made changes in CHANGELOG.md file

Summary by CodeRabbit

  • New Features

    • Introduced gRPC client support, allowing configuration and usage of gRPC clients within the application.
  • Documentation

    • Added comprehensive documentation for gRPC client usage, configuration, and examples in the README.
    • Updated the changelog to reflect the new gRPC client feature.
  • Chores

    • Added the required gRPC client package to dependencies.
    • Extended configuration files to support gRPC client setup.

hungthai1401 avatar Jun 26 '25 09:06 hungthai1401

[!CAUTION]

Review failed

The pull request is closed.

"""

Walkthrough

The changes introduce gRPC client support to the Laravel Bridge package. This includes updates to documentation, configuration scaffolding for gRPC clients, the addition of the necessary dependency, and service provider logic to initialize and register gRPC client services and their dependencies in the application container.

Changes

File(s) Change Summary
CHANGELOG.md Added "Added" section documenting gRPC client support before "Unreleased".
README.md Added gRPC Client usage documentation and updated Table of Contents with new subsection.
composer.json Added "spiral/grpc-client": "^1.0.0-rc1" dependency.
config/roadrunner.php Added 'grpc.clients' configuration section with examples for interceptors and services.
src/ServiceProvider.php Added initializeGrpcClientServices() method; registers FactoryInterface and ServiceClientProvider singletons with config parsing.

Sequence Diagram(s)

sequenceDiagram
    participant LaravelApp
    participant ServiceProvider
    participant Config
    participant Factory
    participant ServiceClientProvider

    LaravelApp->>ServiceProvider: register()
    ServiceProvider->>Config: Read grpc.clients.services & interceptors
    ServiceProvider->>Factory: Register FactoryInterface singleton
    ServiceProvider->>ServiceClientProvider: Register ServiceClientProvider singleton (with config, factory)
    LaravelApp->>ServiceClientProvider: Resolve and use gRPC client

Suggested reviewers

  • butschster

Poem

In the warren of code, a new path appears,
gRPC clients hopping in, greeted by cheers!
With configs and docs, dependencies align,
ServiceProvider magic—connections divine.
Now Laravel bunnies can swiftly connect,
To distant burrows, with TLS checked!
🐇✨ """


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1aa2969fbec07e2bf529afa89145e8429ca34a11 and 0fd23442afbedeca304f786e107efc6f8aa8bbff.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 26 '25 09:06 coderabbitai[bot]

thx a lot!

butschster avatar Jun 27 '25 16:06 butschster

@roxblnfk @butschster good morning, should we have any update?

hungthai1401 avatar Jul 02 '25 00:07 hungthai1401