rnveach
rnveach
To be clear this is not an issue marked easy. We must review the check and all the tokens listed above. We must identify what kind of code each token...
@Binita-tech I think you skipped the most important part, which is what cases does this check and token validate. You gave an example, but you didn't explain what it is...
It is too much to discuss all in one issue, which is why we had separate issues for each item. > Arrays.sort does nothing and can be removed. There is...
> I would like to propose building a Set and querying it instead of sorting We would probably discuss this in a PR. Is there any performance impact from switching...
Issue is approved, but we should look to build cases to kill issues before removing/changing code.
Maybe its too early and I wasn't thinking. I think program is fully terminated when `OutOfMemoryError` occurs as we have no more memory and can't do proper shutdown? I'll try...
`XMLLogger` only closes the file and the root node when [auditFinished](https://github.com/checkstyle/checkstyle/blob/6be04d9e540bb1a76419030b1b608c2960af2692/src/main/java/com/puppycrawl/tools/checkstyle/XMLLogger.java#L125) and [fileFinished](https://github.com/checkstyle/checkstyle/blob/6be04d9e540bb1a76419030b1b608c2960af2692/src/main/java/com/puppycrawl/tools/checkstyle/XMLLogger.java#L141) is called. When `haltOnException` is turned off (by default), [we pass the exception up the chain](https://github.com/checkstyle/checkstyle/blob/6be04d9e540bb1a76419030b1b608c2960af2692/src/main/java/com/puppycrawl/tools/checkstyle/Checker.java#L328) and...
Just a note, XML file is corrupted on other minor exceptions outside of memory. This can occur during `org.antlr.v4.runtime.NoViableAltException`. So there are some valid cases where we should try to...
Travis is showing regression in Orekit. ```` [INFO] There are 9 errors reported by Checkstyle 10.3-SNAPSHOT with /home/travis/build/checkstyle/checkstyle/.ci-temp/Orekit/checkstyle.xml ruleset. [ERROR] src/main/java/org/orekit/forces/maneuvers/ConstantThrustManeuver.java:[197,58] (coding) UnnecessaryParentheses: Unnecessary parentheses around identifier 'getPropulsionModel'. [ERROR] src/main/java/org/orekit/forces/maneuvers/ConstantThrustManeuver.java:[211,58]...
My only question is if DTDs are required, why don't we also require the DTD being used to be one we recognize? What is the purpose of using a custom...