rnp icon indicating copy to clipboard operation
rnp copied to clipboard

tests: avoid ephemeral test suite failure on slow CI

Open dkg opened this issue 2 months ago • 1 comments

In debian's build daemon architecture, some machines are heavily congested (especially for more obscure ports with lower-resourced machines)), and a build can be delayed at any point.

If a build happens to be paused for more than a minute at the wrong time, this test can fail, as it did here, on the sparc64 architecture:

https://buildd.debian.org/status/fetch.php?pkg=rnp&arch=sparc64&ver=0.18.0-4&stamp=1760765792&raw=0

The failure was that the certificate showed as "EXPIRED" instead of "EXPIRES".

This fix isn't a complete fix -- test_set_expires will still fail on some extremely slow machines, for example if the build is delayed by 10 hours at the wrong moment, the subsequent test will fail.

But this should significantly reduce the frequency of build failures.

dkg avatar Oct 18 '25 13:10 dkg

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.46%. Comparing base (bf89f0b) to head (0dcd825).

Additional details and impacted files
@@             Coverage Diff              @@
##           release/0.x    #2368   +/-   ##
============================================
  Coverage        85.46%   85.46%           
============================================
  Files              126      126           
  Lines            22710    22710           
============================================
  Hits             19408    19408           
  Misses            3302     3302           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 18 '25 14:10 codecov[bot]