rnp icon indicating copy to clipboard operation
rnp copied to clipboard

Fix 32 bit assertion

Open dkg opened this issue 2 months ago • 6 comments

dkg avatar Oct 09 '25 21:10 dkg

this doesn't seem to be sufficient for 32-bit platforms. i'm still looking for other issues.

dkg avatar Oct 10 '25 13:10 dkg

@dkg I hope to get back to this and other CI issues during the weekend.

ni4 avatar Oct 10 '25 13:10 ni4

I've just pushed another fix for 32-bit platforms to this branch. these two fixes together combine to let the test suite succeed on debian's armhf platform (which has a 32-bit memory space and a 64-bit time_t). the first patch alone is sufficient to resolve the build on debian's i386 platform (which has 32-bit memory space and 32-bit time_t).

dkg avatar Oct 10 '25 17:10 dkg

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.46%. Comparing base (bf89f0b) to head (1ee82dd).

Additional details and impacted files
@@             Coverage Diff              @@
##           release/0.x    #2363   +/-   ##
============================================
  Coverage        85.46%   85.46%           
============================================
  Files              126      126           
  Lines            22710    22710           
============================================
  Hits             19408    19408           
  Misses            3302     3302           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 10 '25 17:10 codecov[bot]

just a gentle nudge on this. is this patch unacceptable for some reason?

dkg avatar Oct 17 '25 22:10 dkg

@dkg is this commit is good enough for you, so we may close this? https://github.com/rnpgp/rnp/commit/dc417b2427a24729972d3aaef0c08389f073e58c

ni4 avatar Nov 21 '25 14:11 ni4