rnp icon indicating copy to clipboard operation
rnp copied to clipboard

Create v0.17.1 release with `rnp_signature_get_features`

Open ronaldtse opened this issue 1 year ago • 6 comments
trafficstars

Description

Source: https://github.com/rnpgp/rnp/commit/74b70af135d0a1b05fe8ad63aac3f20319ebc4e8#commitcomment-138429079

From @kaie :

Would the RNP team be willing to create a v0.17.1 release, based on the former v0.17.0 release, which adds this feature (commit)? This could allow those Linux distributions which ship RNP separately, to pick up this feature easily, and allow Thunderbird to make use of the new API in its current stable 115.x release.

ronaldtse avatar Feb 09 '24 02:02 ronaldtse

@ronaldtse I think adding https://github.com/rnpgp/rnp/pull/2180 contents to release would be good idea?

ni4 avatar Feb 09 '24 10:02 ni4

Agree with @ni4 . Thanks!

ronaldtse avatar Feb 11 '24 11:02 ronaldtse

...also required to pick CI updates + Botan 3 support + OpenSSL 3.0 fixes (see https://github.com/rnpgp/rnp/pull/2190). @kaie don't you mind these changes? They should not have an impact for already existing behaviour and improve compatibility.

ni4 avatar Feb 27 '24 11:02 ni4

Hi @ni4 - If your intention is to include correctness fixes, plus compatibility fixes for a wider set of build environments and libraries, that makes sense to me. I'd suggest that you ask yourself: Would any long term support environment, that currently ships Thunderbird 115.x, and is willing to take updates for it, but that also wants to minimize the amount of fixes it takes, be fine with your included changes? For example, stable Debian or RHEL? I'd exclude changes those stable environments might be unwilling to bring in.

kaie avatar Feb 28 '24 10:02 kaie

CC @jfx2006

kaie avatar Feb 28 '24 10:02 kaie

@kaie Yeah, this is mostly for systems which updated to Botan 3/latest OpenSSL 3.0 (like https://github.com/rnpgp/rnp/discussions/2159). For LTE nothing would change as they would continue to use older Botan/OpenSSL packages.

ni4 avatar Mar 02 '24 09:03 ni4

Hello, do you expect this to happen very soon, or are you blocked?

kaie avatar Apr 17 '24 16:04 kaie

@kaie The only blocker was this thing : https://github.com/rnpgp/rnp/pull/2209 , however now it seems to be not of that importance as it is easily solvable by maintainers and mostly related to the v0.17.0.

ni4 avatar Apr 17 '24 18:04 ni4

Finally release is published: https://github.com/rnpgp/rnp/releases/tag/v0.17.1

ni4 avatar May 14 '24 08:05 ni4

Thank you. FYI, the release page also says function set_features was added, I assume that's a mistake.

kaie avatar May 14 '24 08:05 kaie