rnp icon indicating copy to clipboard operation
rnp copied to clipboard

Add Pipeline Test for Experimental Crypto Refresh / PQC Features

Open TJ-91 opened this issue 1 year ago • 1 comments

I suggest to build and test the experimental features in the pipeline, that is, add a job that builds with -DENABLE_CRYPTO_REFRESH=On -DENABLE_PQC=On and execute ctest.

On the main branch (Commit aa11f73) building the experimental Crypto Refresh / PQC features fails due to a small mistake:

src/lib/pgp-key.cpp: In member function ‘bool pgp_key_material_t::get_grip(pgp_key_grip_t&) const’:
src/lib/pgp-key.cpp:3035:23: error: ‘key’ was not declared in this scope; did you mean ‘key_t’?
 3035 |             hash->add(key->ed25519.pub);

Without a pipeline test this goes unnoticed

TJ-91 avatar Nov 06 '23 08:11 TJ-91

Agree, we should definitely add some run with PQC, just didn't get to this task yet.

ni4 avatar Nov 08 '23 13:11 ni4