rnp icon indicating copy to clipboard operation
rnp copied to clipboard

Custom Docker images to speed up CI

Open andrey-utkin opened this issue 2 years ago • 1 comments

This changeset introduces the first custom Docker container intended for RNP's CI. This Fedora 35 CI config intends to replace the existing config fedora35-ossl.yml (which is currently broken due to riboseinc repo signature issue). There seems to be no way to trigger GHA to run this CI configuration before it is merged to master. There is also a script ci/docker/fedora35.test-locally which shows how to use this container for local testing.

andrey-utkin avatar Jul 26 '22 15:07 andrey-utkin

Codecov Report

Merging #1884 (a91ee25) into master (712ac3d) will increase coverage by 81.54%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1884       +/-   ##
===========================================
+ Coverage        0   81.54%   +81.54%     
===========================================
  Files           0      138      +138     
  Lines           0    28917    +28917     
===========================================
+ Hits            0    23580    +23580     
- Misses          0     5337     +5337     
Impacted Files Coverage Δ
src/tests/ffi-key-prop.cpp 91.42% <0.00%> (ø)
src/examples/verify.c 65.33% <0.00%> (ø)
src/librepgp/stream-armor.h 90.90% <0.00%> (ø)
src/fuzzing/sigimport.c 100.00% <0.00%> (ø)
src/examples/dump.c 63.63% <0.00%> (ø)
src/tests/fuzz_verify_detached.cpp 100.00% <0.00%> (ø)
src/tests/rnp_tests.cpp 91.66% <0.00%> (ø)
src/lib/crypto/mem.h 100.00% <0.00%> (ø)
src/lib/crypto/ecdsa.cpp 71.94% <0.00%> (ø)
src/tests/rng-randomness.cpp 100.00% <0.00%> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 712ac3d...a91ee25. Read the comment docs.

codecov[bot] avatar Jul 26 '22 15:07 codecov[bot]

Dear reviewers, could you please merge this? Current CI status is irrelevant - neither the product codebase nor the actual CI configuration was changed here. What matters is that after this is merged, the fedora35-lean GHA workflow will start working, and we want to see how it will work in practice.

andrey-utkin avatar Aug 24 '22 16:08 andrey-utkin

Since this is a CI change, one positive review is sufficient for merging. Merging now. Thank you @andrey-utkin !

ronaldtse avatar Aug 24 '22 17:08 ronaldtse