rnp
rnp copied to clipboard
CI failures on release/0.x branch as of v0.16.0
Description
The configured CI jobs (Github Actions) fail in many ways on 0.16.0 release itself, which makes it difficult to build a next patch release on top of it.
Steps to Reproduce
- Create a branch based on v0.16.0 git tag (or release/0.x branch) and add a trivial cosmetic change to the codebase, e.g. a no-op statement to src/lib/rnp.cpp
- push the branch
- create a draft pull request with release/0.x branch as a base
Expected Behavior
All CI checks pass
Actual Behavior
Many CI checks fail. This is my PR demonstrating the issue: https://github.com/rnpgp/rnp/pull/1871
27 failing, 22 successful, 1 skipped, and 1 neutral checks
https://github.com/rnpgp/rnp/runs/7252596896?check_suite_focus=true
Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist
Many runs have this ruby-rnp test suite error:
Failure/Error: expect(@json["expiration"]).to be 63072000
Windows:
could not find any instance of Visual Studio.
D:/a/rnp/rnp/src/common/str-utils.cpp:30:10: fatal error: 'cstddef' file not found
"build" (freebsd?)
pkg: No packages available to install matching 'ruby26' have been found in the repositories
Nickolay said there are fixes on master which should be cherry picked. https://github.com/rnpgp/rnp/pull/1871#issuecomment-1180251635
This is something that would always happen as time flies: expiring keys, updated CI images and runners, changed timestamps and so on. So I don't see a cure from such failures. If you don't have any further questions - feel free to close it as not planned.
There's no cure, but scheduled runs help with discovering it earlier ;) I am going to use this ticket to denote the prerequisite work to backporting of the #1859 patches onto the release branch.
The fix comes in three pieces.
- The minor-stable-release branch (
release/0.x
?) should take three backport commits. https://github.com/rnpgp/rnp/pull/1874 - The master branch of RNP repo should take the increment of version.txt https://github.com/rnpgp/rnp/pull/1873
- ruby-rnp repo should change to distinguish master from the stable branch correctly: https://github.com/rnpgp/ruby-rnp/pull/81
Closing this as it was already resolved during the v0.16.1 release.