Drop CI runs on centos7 with clang in sanitize mode

[andrey-utkin]

Due to false positives.

See #1329.

[codecov[bot]]

Codecov Report

Merging #1803 (853e0cf) into master (d6f871d) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1803   +/-   ##
=======================================
  Coverage   81.12%   81.13%           
=======================================
  Files         137      137           
  Lines       28736    28737    +1     
=======================================
+ Hits        23313    23315    +2     
+ Misses       5423     5422    -1     

Impacted Files	Coverage Δ
src/librepgp/stream-write.cpp	76.86% <0.00%> (-0.10%)	:arrow_down:
src/librepgp/stream-common.cpp	81.35% <0.00%> (+0.36%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6f871d...853e0cf. Read the comment docs.

[ni4]

@andrey-utkin as centos7 has EOL 2024 (see https://github.com/rnpgp/rnp/issues/1329#issuecomment-1098309815 ), should we still remove those sanitize runs? cc @ronaldtse

[ronaldtse]

@ni4 I think it is time to drop CentOS 7, just like how some other vendors are doing it:

• https://github.com/rabbitmq/rabbitmq-server/discussions/4637

In fact I think RabbitMQ's strategy is pretty good. Perhaps we should do a blog post announcement of CentOS 7 deprecation? @andrey-utkin would you have time to help us do that?

[ni4]

@ronaldtse If I understand correctly, RNP didn't get into CentOS 7 packages, and the only way to build it from sources? I.e. we'll just remove CI runs but will not drop CentOS 7 support, as we don't have anything in codebase/dependencies which doesn't build there.

[andrey-utkin]

we'll just remove CI runs but will not drop CentOS 7 support

I think it's widely expected that distros which are claimed to be supported are actually tested in CI.

Note that this pull request is smaller in scope than what you guys are discussing - it was about dropping a run with sanitizer, which caused some pain with a false positive (which by now has been worked around).

I'd suggest to not do any deliberate deprecation moves right now unless we have some growing pain related to it. Do we have any? I'm not feeling it and I'm not aware of you guys feeling it.

If we decide to go for it, I'd be glad to assist with announcing it.

[ni4]

Let's close this as there is no major issues with Centos 7 CI Runs. We'll be able to do that later in a separate PR once needed.