maps icon indicating copy to clipboard operation
maps copied to clipboard

Update MapView.md

Open SethArchambault opened this issue 1 year ago • 2 comments

fixed h3 markdown

Description

Fixes #

Added your feature that allows ...

Checklist

  • [ ] I've read CONTRIBUTING.md
  • [ ] I updated the doc/other generated code with running yarn generate in the root folder
  • [ ] I have tested the new feature on /example app.
    • [ ] In V11 mode/ios
    • [ ] In New Architecture mode/ios
    • [ ] In V11 mode/android
    • [ ] In New Architecture mode/android
  • [ ] I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Component to reprocuce the issue you're fixing


SethArchambault avatar Mar 06 '24 22:03 SethArchambault

@SethArchambault thank much but this is a generated file and needs to be fixed in the template

mfazekas avatar Mar 07 '24 07:03 mfazekas

As @mfazekas already mentioned, this has to be fixed in either: scripts\templates\component.md.ejs

<%- getMarkdownMethodExamples(method) %>
<%- exampleMethodLinks(method, component) -%>


<%_ } _%>

Which would add additional new lines to all method definitions, which does not look nice (and already happens sometimes)

or

scripts\autogenHelpers\globals.mjs

export function exampleMethodLinks(method, component) {
  const key = `${component.name}#${method.name}`;
  if (global.exampleTagLinks[key]) {
    return global.exampleTagLinks[key]
      .map(({ groupName, name, title }) => {
        return `[${title}](../examples/${groupName}/${name})`;
      })
      .join(', ')
      .concat('\n\n');
  }
  return '';
}

VolkerLieber avatar May 26 '24 13:05 VolkerLieber