fountain-mode icon indicating copy to clipboard operation
fountain-mode copied to clipboard

Makefile clean target doesn't work with GNU make

Open sten0 opened this issue 2 years ago • 4 comments

Hi Paul,

While importing the latest release into Debian, I noted the clean target was broken, but I'm assuming that you don't see it because you're on macOS and are using BSD make.

This is the problem: https://github.com/rnkn/fountain-mode/blame/f3685ac7235de79cfa9a9c84acbbe8541bcf5e25/Makefile#L60

Please let me know if you'd like to support developers who use GNU (rather than BSD) systems, as well as if you'd prefer the one-line solution that calls find, or something else.

sten0 avatar Nov 29 '23 20:11 sten0

Thanks for the heads up. I've only considered the Makefile as a convenience thing for me, so portability hasn't been a huge concern, but if you have a fix, by all means!

rnkn avatar Nov 30 '23 05:11 rnkn

I just tested with GNU Make versions 3.81 (macOS) and 4.4.1 (gmake, MacPorts) and didn't get any errors, but if you could let me know what needs to change that would be great!

rnkn avatar Jun 28 '24 01:06 rnkn

I just tested with GNU Make versions 3.81 (macOS) and 4.4.1 (gmake, MacPorts) and didn't get any errors, but if you could let me know what needs to change that would be great!

Hm, well, it didn't look like shell expansion last I looked...oh! I bet macOS comes with a library of convenient macro expansions that are enabled by default (I'm assuming this isn't a user config thing).

I've been waiting for your reply to learn if you'd like a PR that uses native makefile (uglier, bigger, but works everywhere) or the conventional method of calling 'find' (might not work on Windows). Alternatively, if you can ant to do it yourself, there are lots of resources online about these two methods.

sten0 avatar Jul 02 '24 19:07 sten0

Yes please send a patch if it's not working for you! I think the first way, the native Makefile would be best.

rnkn avatar Jul 03 '24 00:07 rnkn