web-components-loader icon indicating copy to clipboard operation
web-components-loader copied to clipboard

Sensible default for outputPublicPath

Open eric-burel opened this issue 6 years ago • 2 comments

I am not at all a webpack expert, so this change may not be appropriate. However when writing my own config, I did not need a public path, default being '/'. So I think we should rely on this default when computing the component path (but once again I am not a webpack expert).

eric-burel avatar Feb 13 '18 10:02 eric-burel

Was this change created to fix a bug of some sort or improve the library, or is this just a "i think it should be this way" type of change?

rnicholus avatar Feb 13 '18 15:02 rnicholus

Hi, It is more a small improvement. Sometime you don't set the publicPath in your output config, because Webpack provide its own default value (/). So I had to seek for this value and to set it manually in order to use your loader. It is not a bug per se but one should not need to change the output config in order to set a loader. But I can't guarantee that there is no regression whatsoever, take it as a proposal.

eric-burel avatar Feb 13 '18 15:02 eric-burel