Ray Nicholus
Ray Nicholus
@manvesh Check out #1597. It needs unit test work, and I have yet to review the changes.
@SinghSukhdeep can you take a peek at this?
Everything looks fine here, but I'm not sure I understand the documentation changes. You shouldn't have to explicitly reference an index.js file when importing a module, unless I'm missing something....
Is it really necessary to reference index.js directly? I’ve never had to do that myself.
So, does this there are no breaking changes then?
If any user using the library in an expected/documented manner needs to adjust their code to upgrade, then the version contains breaking changes, and that must always be avoided in...
I think i'm ok with this provided the documentation changes are reverted. But I do want to do a bit of manual testing myself first. Thanks both of you for...
I’m personally fine with just leaving the docs as-is (before any changes). It’s common to use the index.js pattern (I’m using it in several closed and open source projects) and...
I’m fairly certain everything will just work without making any code changes in webpack environments. I’ll have to confirm though. But if indeed this does break for users of rollup,...
To ensure we don't break backwards compatibility, can't we just keep the traditional.js, s3.js, etc files?