couchdb-lucene icon indicating copy to clipboard operation
couchdb-lucene copied to clipboard

Lucene 3.6.2, POST queries, full OOXML schemas, increase granularity of Date queries

Open vjt opened this issue 11 years ago • 8 comments

Hi Robert,

as discussed on the couchdb-user mailing list, this pull request contains a batch of changes that we found useful in our production environment.

Details are in the commit messages and in the NEWS file.

This contains @patricklodder's commit from #170, closing also #112.

Thanks!

~Marcello

vjt avatar Dec 08 '13 16:12 vjt

I'm taking the commits individually that can go in unmodified. The precisionStep thing will need to be configurable and the POST variant (which is a great idea) might be done more cleanly (not sure yet).

rnewson avatar Dec 09 '13 15:12 rnewson

Thank you! As you may have inferred, I am not a Java developer, so I basically cargo-culted the POST code and just tested it from the outside, issuing big HTTP requests.

About precisionStep, definitely a configuration option is the best way forward - I tried to implement it but I failed - again, no Java developer here :-).

Thanks again, and looking forward to the developments.

~Marcello

vjt avatar Dec 11 '13 10:12 vjt

@rnewson I'm happy to donate some time to clean up the POST code, it is indeed a bit ugly. If you have any specific feedback on what is unacceptable right now, please let me know, so I can focus on that.

patricklodder avatar Dec 11 '13 11:12 patricklodder

@patricklodder I don't have any specific objections right now, only that it looked a little odd to me. I'll take some time over the holidays to look at it. It's definitely useful to have a POST variant.

rnewson avatar Dec 11 '13 11:12 rnewson

Hi @rnewson, I've extracted licensing information for all the included dependencies in a new text file. I don't think there's a better way for now, as Maven doesn't provide structured licensing information for all the artifacts, so I had to find the home pages of each dependency and find out which license they are released under.

vjt avatar Jan 03 '14 17:01 vjt

Thanks, but I'm not sure it's necessary (and it's not related to this pull request, I think).

rnewson avatar Jan 03 '14 17:01 rnewson

OK. Yes, it is definitely OT here - sorry for the noise.

vjt avatar Jan 03 '14 17:01 vjt

No problem. :) I hope to finish extracting the work here into master next week, the simple bits are already done.

rnewson avatar Jan 03 '14 17:01 rnewson