gh-slack icon indicating copy to clipboard operation
gh-slack copied to clipboard

users response not OK - limit_required

Open rmoff opened this issue 1 year ago • 1 comments

This tool is great - it works really well, except on one Slack group:

gh slack read https://example.slack.com/archives/C1M5388TF/p1688463409836309
Error: users response not OK: {"ok":false,"error":"limit_required"}

There are ~30k users on this Slack, so perhaps this is the issue

If the collection is too large you may experience limit_required

rmoff avatar Jul 05 '23 07:07 rmoff

👋 Apologies for the slow reply, my notifications were going to a defunct email address. This should be fairly simple to address by adding paging to the users call https://github.com/rneatherway/gh-slack/blob/211b567ee13226729ae0162620989cff8a0ec528/internal/slackclient/client.go#L358

You could use this function as an example: https://github.com/rneatherway/gh-slack/blob/211b567ee13226729ae0162620989cff8a0ec528/internal/slackclient/client.go#L316

I'd be happy to review such a PR, or may get to it myself at some point!

rneatherway avatar Aug 14 '23 19:08 rneatherway

This should be fixed by https://github.com/rneatherway/gh-slack/pull/61. Would you like to give it a test @rmoff?

rneatherway avatar Jun 11 '24 10:06 rneatherway

Yes, happy to test it - how would i do that? :)

rmoff avatar Jun 11 '24 10:06 rmoff

Great! If you checkout the PR and then run

go run ./cmd/gh-slack/ read https://example.slack.com/archives/C1M5388TF/p1688463409836309

that should be equivalent to the command that you pasted above.

rneatherway avatar Jun 11 '24 11:06 rneatherway

Works perfectly. thanks!

rmoff avatar Jun 11 '24 13:06 rmoff

Released!

rneatherway avatar Jun 11 '24 16:06 rneatherway