Robin Neatherway

No problem at all, thanks for the guidance :+1:

:wave: I've had a go at this and put together a function of this signature: ```golang type Selection struct { StartLine int StartCol int EndLine int EndCol int } func...

Sorry to prod, but if you have any advice on wiring this up I'd be interested to try that too.

> What you've done looks good! I think there is a utility that may be helpful, which operates similarly to your algorithm: > https://pkg.go.dev/golang.org/x/[email protected]/go/ast/astutil#PathEnclosingInterval Oh nice, thanks! I've simplified the...

Same here. Is there any way that we could move the discussion forward on which solution might be workable? > To match Windows behaviour, we should emit app-command events and...

@findleyr I've got a branch visible at https://github.com/golang/tools/compare/master...rneatherway:tools:selectionrange?expand=1 including extending the tests to support this new case. A few things came up while working on it that I'd appreciate your...

I got far enough that I decided to open the pull request: https://github.com/golang/tools/pull/416 I guess my last question would be whether you had any advice on how to test this...

> @hyangah do we need to register a new selection range provider? It may be that this needs a vscode-go change as well. I've got a feeling that we need...

> Thanks for implementing the feature. That's neat. > VSCode Go uses LSP so the server needs to announce this new capability. Ah thanks! I wasn't sure how the final...

:wave: Code Scanning assumes that the locations are for files in the repository. As a result it is trying to relativize your URLs against a `file://` URL that is the...