Sebastian Gumprich

Results 113 comments of Sebastian Gumprich

Should be fixed for some time now here: https://github.com/dev-sec/ansible-collection-hardening/pull/437 and here https://github.com/dev-sec/ssh-baseline/pull/209

I jsut checked, `pam_limits` was already in community.general 1.0.0. @Mike-Zelixon, if you still have problems, please open a new issue. Thanks!

Good question, @nejch. I think you're right. Additionally since merely adding audit-rules (and not acting upon them) provides no additional security. It's basically the same as [here](https://github.com/dev-sec/linux-baseline/issues/149): Merely having rsyslog...

Hey @ImNtReal, would you mind creating some integration-tests for this PR? :)

Yes, you're right. This functionality is missing. Do you want to create a PR to tackle this?

> AFAIK this requires only changes in the [module_utils/base.py](https://github.com/ansible-collections/community.grafana/blob/main/plugins/module_utils/base.py#L39) argument_spec, right? The argument_spec is not used in the lookup-plugin, so this will probably not work. > Or am I wrong...

I think adding the missing options to the `GrafanaAPI` class should be sufficient.

I'm not sure about this. Why not just copy the code, make changes to it and then run it? After all you already have the code for the first object...

I'm still not sure about this. I think "you're holding it wrong" - your workflow seems to be at odds with Ansible. Here's an example playbook to clone things: ```...

@rrey, should we merge this regularly?