qtractor icon indicating copy to clipboard operation
qtractor copied to clipboard

Switch from libmad to libmpg123

Open Jacalz opened this issue 6 years ago • 4 comments

Libmad is dead and has not been updated for a long time. It would be best to switch the mp3 encoding to something that is up to date and much more modern. I would recommend something like libmpg123. https://mpg123.de/

Original description about minimp3:

With the mp3 specification being opened up, the possibility of seeing new open source mp3 libraries has improved massively. The current library called libmad is dead and unmaintained since a few years back, with nothing happening on that front. I would advice looking in to https://github.com/lieff/minimp3 as a replacement for a dead library. The new library looks to be simple, fast and modern. In other pretty much all that libmad isn't in my opinion :)

Jacalz avatar Dec 06 '19 20:12 Jacalz

I don't know if I call that being worked on, but that's great :+1:

Jacalz avatar Dec 06 '19 21:12 Jacalz

What do you mean switch from libmad? libmad was never used by libsndfile, neither any other mp3 decoding library for that matter.

Also, FWIW, mp3 is being implemented using libmpg123

rjamorim avatar Dec 13 '19 23:12 rjamorim

Nobody has said that libmad was used by libsndfile, but it is an optional dependency of qtractor for mp3 encoding. Since libmad is dead, I opened this task in order to recommend change it to soemthing else and I choose minimp3 as it is was Ardour recently added support for. libmpg123 might be a better option though...

EDIT: You are correct. Libmpg123 seems to be a much better option than minimp3 👍

Jacalz avatar Dec 14 '19 09:12 Jacalz