qjackctl icon indicating copy to clipboard operation
qjackctl copied to clipboard

graph is blurry on high DPI macOS with Qt5

Open Be-ing opened this issue 3 years ago • 6 comments

Environment

  • QJackCtl Version: 0.9.6
  • JACK Version: 1.9.20
  • Operating System: macOS 11.5.2
  • Installation: https://jackaudio.org/downloads

Steps To Reproduce

Open QJackCtl distributed with JACK on macOS and click the Graph button

Expected vs. actual behavior

The connection graph in the QJackCtl build shipped with the macOS version of JACK does not scale well for high DPI screens. Everything within the graph is blurry but the text at the top of the window scales okay: Screen Shot 2022-02-06 at 7 36 47 PM

Be-ing avatar Feb 07 '22 01:02 Be-ing

can't argue about macosx, but the Graph scales quite well and sharply on Linux X11/Wayland (Qt6.2)

rncbc avatar Feb 07 '22 09:02 rncbc

This issue does not occur with QJackCtl from Homebrew which is built with Qt 6.2.2:

Screen Shot 2022-02-07 at 8 20 27 AM

I think this can be fixed by setting the Qt::AA_EnableHighDpiScaling when building with Qt5. This was removed in Qt6; high DPI scaling is always enabled in Qt6.

Be-ing avatar Feb 07 '22 14:02 Be-ing

The graphics are still blurry because they're all low resolution rasters.

Be-ing avatar Feb 07 '22 14:02 Be-ing

I think this can be fixed by setting the Qt::AA_EnableHighDpiScaling when building with Qt5.

maybe you wanna have a look around here: https://github.com/rncbc/qjackctl/blob/e3c15c65c7628e13795d3eaff78a0de279737bc0/src/qjackctl.cpp#L557

  • it's been enabled for Qt5 where applicable, and disabled for Qt6 for good measure.

rncbc avatar Feb 07 '22 14:02 rncbc

Hmm, if that's already implemented then I'm nos sure what else could be the issue.

Be-ing avatar Feb 07 '22 15:02 Be-ing

issue (probably) lies on an old Qt5 perhaps?

rncbc avatar Feb 07 '22 15:02 rncbc