Nick Cross

Results 56 comments of Nick Cross

I do agree the macros are harder to follow and make maintenance more complex. I have no objections to refactoring to make it easier to maintain/support.

I think this was expected given the discussion on https://github.com/cekit/cekit/issues/886 ?

@ricardozanini As you raised #886 I think you should be aware of this. @jmtd If that directory is being left, this means the sqllite DB is then still there. Does...

@ricardozanini Thanks for the input. I agree with using a new separate ticket to focus on reproducible builds. If I recall @jmtd in #886 you mentioned about not removing certain...

@jmtd You'll need to rebase to pick up the MacOS fixes from #909

Thanks for the PR! Currently I _don't_ have kwalletcli installed. As a compromise how about we check for whether its installed, use it if is, else fall back to qdbus?

While I agree with @hazendaz in that I don't believe its anything per se to do with a BOM I do however think this minor change would be good to...

I'm pasting this here from 888 : ``` I think at the time I did that to make sure the multistage was accurately building what the users wanted. While fiddly...

Stylish works fine; I used a customised https://userstyles.org/styles/117727/firefox-private-tab-badge

I agree and I think this is an artifact of the age of the codebase which evolved over time. I like the idea of separating out the disk based representation...