Markus Vogl
Markus Vogl
As all of this was half a year ago, I've got no files checked out for all of that and I currently don't have time to work myself in again,...
The only test failing is the jest snapshot, and that works as intended as the UI does change, compared to the previous version (see screenshot)
I rebased and for me, on my branch, the codecov stuff doesn't run. I also added a test for the python error case. But I guess I'd need to add...
@mhils should be fine now. Problem was, that a unary ! is interpreted as a regex, and therefore a valid filter. Made it a "[" which isn't a valid regex.
@alwqx i did your suggested changes + rebased. All your suggestions made perfect sense, so i gave you collaborator access to my fork if you want to suggest any other...
Works for me, should be handled by [Assessment.java#L135](https://github.com/marunjar/anewjkuapp/blob/master/aNewJKUApp/src/main/java/org/voidsink/anewjkuapp/kusss/Assessment.java#L135) so i guess this can be closed?