Ryan Burn

Results 39 comments of Ryan Burn

What options do you want to configure from environmental variables? Keep in mind that by default nginx drops all the environmental variables when it forks a worker. http://nginx.org/en/docs/ngx_core_module.html#env

What do you mean? The source code is in the repository and there are instructions on how to build the module in the README https://github.com/opentracing-contrib/nginx-opentracing#building-from-source

@etsangsplk - Could you propose a description?

All the languages are being moved into separate repos: [python](https://github.com/opentracing-contrib/python-grpc), [go](https://github.com/opentracing-contrib/go-grpc), [java](https://github.com/opentracing-contrib/java-grpc)

Looks like the CI failed because the OS X build timed out -- maybe try running again, it might not be an actual issue with the PR

Did you try building with `cmake -DBUILD_SHARED_LIBS=OFF`? -- that should produce only the static library.

My guess is it has something to do with this [OPENTRACING_API](https://github.com/opentracing/opentracing-cpp/blob/master/include/opentracing/symbols.h) macro applied before the [variable declarations](https://github.com/opentracing/opentracing-cpp/blob/master/include/opentracing/ext/tags.h#L23-L29). Could you investigate to see if it should be set to something else...

Or use InitGlobal(nullptr) I think the intention of IsGobalTracerRegistered was to query whether a global tracer was ever registered, but maybe @MikeGoldsmith can clarify?

Yes, it seems as if the problem is that they're not escaped correctly. I don't know that it's important for apache - but if they're going to be fixed, I...