Rano | Ranadeep

https://github.com/cosmos/ibc-rs/blob/5e7ff8e42c15592cff22a14536cc479f08cf8024/Cargo.toml#L107 `"full"` feature is deprecated and [doesn't enable anything](https://github.com/paritytech/parity-scale-codec/blob/a1c9b026a6d6a5ed7f1eebbf7aeb97177420abc6/Cargo.toml#L55). Rather this should be `"derive"`. --- Although, there is an interesting scenario with `scale-info` dependency. ```rs #[derive(parity_scale_codec::Encode, parity_scale_codec::Decode)] pub struct Signer(String);...

bug(core): client creation only checks if the client is frozen

4

## Bug Summary only non-frozen status is checked at client creation. we should just check if the client is active. ## Details https://github.com/cosmos/ibc-rs/blob/3b260e209ec6111c1dc2520d14f65fd605fdc834/ibc-core/ics02-client/src/handler/create_client.rs#L35 ~should be refactored to `if !status.is_active() {...

Support IBC Client Params

1

## Feature Summary Right now, ibc-rs doesn't support IBC Client params. With Client params, the host chain can disable or enable supported client types via governance. ## Proposal Let me...

## Feature Summary ibc-rs will begin supporting gRPC endpoints via a blanket implementation (#842). It should be tested via mock context. ## Proposal Implement the required traits for mock context...

deprecate `GrowingStore` and `RevertibleStore`

1

Close #181 These two stores are incorrect. - GrowingStore doesn't implement deletion. Instead, it stores an empty byte array at the deleted key. This is not correct for generating non-membership...

Now that `InMemoryStore` natively supports deletion (#141) and rollback (#160) - we can deprecate `GrowingStore` and `RevertibleStore`.

We need to generalize our store implementation so that it can support: - [`tendermint_spec`](https://docs.rs/ics23/latest/ics23/fn.tendermint_spec.html) - [`iavl_spec`](https://docs.rs/ics23/latest/ics23/fn.iavl_spec.html) Differences: - Prepending during hashing: This is easily solvable by applying a closure during...

#### Bug in `next_consensus_state` The following comparison should be reversed. https://github.com/informalsystems/basecoin-rs/blob/57f47f2770d86888064f56af7b784d3521869028/basecoin/modules/src/ibc/client_contexts.rs#L201-L203 #### Refactor `prev_consensus_state` We can simplify the `prev_consensus_state` as `next_consensus_state` if we reverse the iterator here. https://github.com/informalsystems/basecoin-rs/blob/57f47f2770d86888064f56af7b784d3521869028/basecoin/modules/src/ibc/client_contexts.rs#L233 [ref impl...

https://github.com/informalsystems/basecoin-rs/blob/57f47f2770d86888064f56af7b784d3521869028/basecoin/app/src/abci/v0_38/tendermint.rs#L124-L137 ~Currently, the basecoin app uses a single tree for the whole app state. So, this essentially increases the chain height multiple times.~ ~Also, we update the module identifier paths...

Currently `basecoin-store` only returns membership proofs.